Skip to content

Conversation

@diana-villalvazo-wgu
Copy link
Contributor

@diana-villalvazo-wgu diana-villalvazo-wgu commented Nov 5, 2025

Description

It covers the first and fourth point of the acceptance criteria for #30

A table lists all granted extensions with the following columns:

  • User Name
  • Full Name
  • Email
  • Graded Subsection
  • Extended Due Date
  • Reset Action
    The list supports pagination with 25 per page.

Screenshot

Screenshot 2025-11-05 at 5 11 28 p m

Link to test when MFE is running: http://apps.local.openedx.io:8081/instructor/course-v1:OpenedX+DemoX+DemoCourse/date_extensions

Support Information

Closes #56

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Nov 5, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @openedx/committers-frontend-app-instruct.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.78%. Comparing base (5b0d465) to head (8726fc3).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/dateExtensions/data/api.ts 0.00% 4 Missing ⚠️
src/dateExtensions/data/apiHook.ts 0.00% 3 Missing ⚠️
src/dateExtensions/data/queryKeys.ts 0.00% 3 Missing ⚠️
src/dateExtensions/DateExtensionsPage.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #62       +/-   ##
==========================================
+ Coverage   0.00%   73.78%   +73.78%     
==========================================
  Files          5       32       +27     
  Lines          7      267      +260     
  Branches       0       59       +59     
==========================================
+ Hits           0      197      +197     
- Misses         7       70       +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diana-villalvazo-wgu diana-villalvazo-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Nov 5, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 56/date-extensions-list branch 2 times, most recently from 120fcc7 to 00c39fb Compare November 6, 2025 00:03
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Needs Triage to Waiting on Author in Contributions Nov 6, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 56/date-extensions-list branch 2 times, most recently from 1c84589 to f075e8d Compare November 13, 2025 15:39
Copy link
Contributor

@wgu-jesse-stewart wgu-jesse-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good foundation for the date extensions feature! My main concerns are around query key caching; all courses and pages share the same query key, causing React Query to incorrectly return cached data from Course A when you navigate to Course B or switch pages. I'm approving, because I'm not actually sure if this is an issue without testing it.

The test coverage is solid, and the component structure is clean.

@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 56/date-extensions-list branch 2 times, most recently from c20cb7a to 1549033 Compare December 5, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

Date Extensions: Display list with pagination

4 participants